This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Add additional attributes support #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2018 21:47
Allows to add additional attributes to the imageset output. Signed-off-by: Mike Wink <[email protected]>
This commit adds the missing attributes variable init and also adds a check for empty attribute values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for extra attributes in kirby-imageset output.
It's not a perfect solution, but hopefully good enough or at least a basis for further enhancements. I needed to add title and rel attributes and did not see an easy way to do it.
I think a better solution would be to refactor attribute handling, where if you add more key-value pairs to the options array they will automatically be sanitised and handled as extra attributes.