Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OIFITS library calls to use the v1.0 syntax #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bensetterholm
Copy link
Contributor

OITOOLS previously used a forked version of the OIFITS library, which is at this point a few years old. In the meantime, OIFITS has matured to v1.0 and the syntax is different from the version used in this code. This pull request updates all of the calls to OIFITS based on the new syntax.

As an end-user of OITOOLS, it is too much effort to have to maintain environments for the separate versions of OIFITS as well as having to remember the two different ways of doing things. ;)

Notes:

  1. It looks like the only thing that the forked OIFITS library adds is T4 support. However, it looks like all T4 related functionality in OITOOLS has been commented out for a long time.
  2. Make sure that you remove the link to the forked and manually installed OIFITS library. Then, when updating OITOOLS on your local machine, it will pull the Eric's "official" version from the General registry.
  3. I also removed the Manifest.toml file, since this is your machine specific and should not be in the repo. You should probably update your .gitignore file unless you still have a good reason to keep the Manifest around.

@fabienbaron
Copy link
Owner

Thanks Ben, I will test on my OIFITS collection and merge afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants