-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new TimSpan
overload support coming from .NET 9
#3994
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
8eebc37
to
ed4bb77
Compare
The remaining failing CI probably needs #3960, we should be able to work around this limitation by using compiler directives. |
I found out that the Rust target create one function per overload, this can be seen here for example: Fable/src/fable-library-rust/src/TimeSpan.rs Lines 38 to 61 in a61b29d
I will do something similar for supporting the new TimeSpan overload. |
@ncave Is When trying to run it I have this error:
Even if the IDE in VSCode is able to find the |
Fixed in #4001 |
Yes, using FABLE_COMPILER_5 should work. You can merge it as is, I can add the Rust part in a separate PR if you prefer. |
… micro second is provided when targeting JS/TS
ed4bb77
to
009b223
Compare
Thank you, I had a look at adding Rust support but this is not add straightforward as it seemed to me. I will look at your PR to learn from it. |
#3985