Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and modified synonym file #51

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Added and modified synonym file #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions tests/synonyms/license_synonyms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"BSD-2": "bsd-simplified",
"WTFPL": "unknown",
"LICENSE": "unknown",
"or (at your option) any later version.": "unknown",
"Apache2": "apache 2.0",
"Apache2": "apache 2.0",
"MITNFA": "unknown",
"GNU Affero General Public License v3": "affero gplv3",
"MIT http://www.opensource.org/licenses/mit-license.php": "mit",
Expand Down Expand Up @@ -65,8 +64,7 @@
"LGPL 3": "lgplv3",
"Apache License": "apache v?",
"3-Clause BSD License": "bsd-new",
"see LICENCE file": "unknown",
"STMPL": "unknown",
"STMPL": "unknown",
"GPL with exceptions or ZPL": "unknown",
"3-clause BSD License": "bsd-new",
"CDDL/GPLv2+CE": "unknown",
Expand Down Expand Up @@ -211,7 +209,7 @@
"Modified BSD License": "bsd-new",
"Python style": "unknown",
"Common Public License Version 1.0": "cpl 1.0",
"MPL 2.0 or EPL 1.0": "unknown",
"MPL 2.0 or EPL 1.0": "mpl 2.0",
Copy link
Contributor

@miteshvp miteshvp Jan 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a random comment, but I feel that we should have lowercase letters for everything here and should be handled via program. In this way we can avoid something like
MPL 2.0 or EPL 1.0 -> mpl 2.0
mpl 2.0 or epl 1.0 -> mpl 2.0
Mpl 2.0 or Epl 1.0 -> mpl 2.0
Note - This applies to all the keys -> value here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miteshvp Yes, we have had this discussion before, we have to modify this file to all things lower case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I had the same discussion with sara yesterday. If we convert all the input licenses names into lowercase before passing it to our platform that way we can reduce the list of synonyms.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miteshvp #52 we can track it here. :)

"GPLv3": "gplv3",
"PayPal SDK License": "unknown",
"GNU Library or Lesser General Public License (LGPL)": "lgpl v?",
Expand Down Expand Up @@ -258,9 +256,8 @@
"Newsletr": "unknown",
"BSD New": "bsd-new",
"BSD Simplified" : "bsd-simplified",
"MIT or Apache License": "unknown",
"or distribute this software": "unknown",
"AAL": "unknown",
"MIT or Apache License": "apache 2.0",
"AAL": "unknown",
"BSD with attribution": "unknown",
"BSD with advertising": "unknown",
"New BSD License": "bsd-new",
Expand All @@ -275,8 +272,7 @@
"LPGL": "lgpl v?",
"Apache License, Version 2.0": "apache 2.0",
"Apache-2.0": "apache 2.0",
"LICENSE.txt": "unknown",
"Creative Commons Attribution-Noncommercial-Share Alike license": "unknown",
"Creative Commons Attribution-Noncommercial-Share Alike license": "unknown",
"sell": "unknown",
"LGPL 2.1": "lgplv2.1",
"License :: OSI Approved :: BSD License": "unknown",
Expand All @@ -302,8 +298,7 @@
"Jedis License": "unknown",
"GPL2": "gplv2",
"ZPL 2.1": "unknown",
"(specified using classifiers)": "unknown",
"Atomikos Multiple Licensing Scheme": "unknown",
"Atomikos Multiple Licensing Scheme": "unknown",
"Apache v2.0": "apache 2.0",
"GPL2 w/ CPE": "unknown",
"Apache License Version 2.0": "apache 2.0",
Expand Down Expand Up @@ -336,7 +331,7 @@
"COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 2.0": "cddlv1.1+",
"Unlicense": "unknown",
"all rights reserved": "unknown",
"MPL 2.0, and EPL 1.0": "unknown",
"MPL 2.0, and EPL 1.0": "mpl 2.0",
"ARL": "unknown",
"NCSA": "unknown",
"Open Software License": "unknown",
Expand Down