Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO BE CLOSED: Endpoints to scan user notification and notify users #68

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

samuzzal-choudhury
Copy link
Contributor

No description provided.

@samuzzal-choudhury samuzzal-choudhury changed the title Endpoints to scan user notification and notify users WIP: Endpoints to scan user notification and notify users Jun 11, 2018
@samuzzal-choudhury
Copy link
Contributor Author

[test]

1 similar comment
@samuzzal-choudhury
Copy link
Contributor Author

[test]

@samuzzal-choudhury samuzzal-choudhury force-pushed the user_notification branch 2 times, most recently from a9a15cd to f533d1b Compare June 11, 2018 13:16
@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

1 similar comment
@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@samuzzal-choudhury
Copy link
Contributor Author

[test]

@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@tisnik
Copy link
Member

tisnik commented Jun 21, 2018

[test]

@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@samuzzal-choudhury
Copy link
Contributor Author

[test]

@centos-ci
Copy link
Collaborator

@samuzzal-choudhury Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-gemini-server:SNAPSHOT-PR-68

@@ -73,6 +73,21 @@ objects:
secretKeyRef:
name: aws
key: s3-secret-access-key
- name: GEIMINI_SA_CLIENT_ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo here. Should be GEMINI_SA_CLIENT_ID.

@@ -48,6 +49,39 @@ def get_audiences():
return getenv('BAYESIAN_JWT_AUDIENCE').split(',')


def init_auth_sa_token():
"""Initialize a service token from auth service."""
auth_server_url = getenv('AUTH_SERVICE_HOST', 'https://auth.prod-preview.openshift.io')
Copy link
Contributor

@abs51295 abs51295 Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't expose the auth prod-preview url, instead return an empty string '' and check for validity of auth_server_url before proceeding.

auth_server_url = getenv('AUTH_SERVICE_HOST', 'https://auth.prod-preview.openshift.io')
endpoint = '{url}/api/token'.format(url=auth_server_url)

client_id = getenv('GEIMINI_SA_CLIENT_ID', 'id')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before.

@samuzzal-choudhury samuzzal-choudhury changed the title WIP: Endpoints to scan user notification and notify users TO BE CLOSED: Endpoints to scan user notification and notify users Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants