-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TO BE CLOSED: Endpoints to scan user notification and notify users #68
base: master
Are you sure you want to change the base?
TO BE CLOSED: Endpoints to scan user notification and notify users #68
Conversation
[test] |
1 similar comment
[test] |
a9a15cd
to
f533d1b
Compare
@samuzzal-choudhury Your image is available in the registry: |
1 similar comment
@samuzzal-choudhury Your image is available in the registry: |
[test] |
@samuzzal-choudhury Your image is available in the registry: |
[test] |
5127128
to
2fb3577
Compare
@samuzzal-choudhury Your image is available in the registry: |
@samuzzal-choudhury Your image is available in the registry: |
@samuzzal-choudhury Your image is available in the registry: |
@samuzzal-choudhury Your image is available in the registry: |
[test] |
@samuzzal-choudhury Your image is available in the registry: |
@@ -73,6 +73,21 @@ objects: | |||
secretKeyRef: | |||
name: aws | |||
key: s3-secret-access-key | |||
- name: GEIMINI_SA_CLIENT_ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a typo here. Should be GEMINI_SA_CLIENT_ID
.
@@ -48,6 +49,39 @@ def get_audiences(): | |||
return getenv('BAYESIAN_JWT_AUDIENCE').split(',') | |||
|
|||
|
|||
def init_auth_sa_token(): | |||
"""Initialize a service token from auth service.""" | |||
auth_server_url = getenv('AUTH_SERVICE_HOST', 'https://auth.prod-preview.openshift.io') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't expose the auth prod-preview url, instead return an empty string ''
and check for validity of auth_server_url
before proceeding.
auth_server_url = getenv('AUTH_SERVICE_HOST', 'https://auth.prod-preview.openshift.io') | ||
endpoint = '{url}/api/token'.format(url=auth_server_url) | ||
|
||
client_id = getenv('GEIMINI_SA_CLIENT_ID', 'id') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before.
No description provided.