[DNM] Modifying Java Jenkifiles to support the osio pipeline library #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrishin
requested changes
Feb 5, 2019
maven/Release/Jenkinsfile
Outdated
|
|
||
| // processing openshift template present in .openshiftio/application.yaml | ||
| def resources = processTemplate(params: [ | ||
| release_version: "1.0.${env.BUILD_NUMBER}" |
There was a problem hiding this comment.
@rupalibehera could you make it as RELEASE_VERSION (all uppercase)
sthaha
reviewed
Feb 11, 2019
maven/Release/Jenkinsfile
Outdated
| } | ||
| } | ||
| integrationTestCmd = "mvn verify integration-test -Dnamespace.use.current=false -Dnamespace.use.existing=${testNamespace()} -Dit.test=*IT -DfailIfNoTests=false -DenableImageStreamDetection=true -Popenshift,openshift-it" | ||
| runTest commands: integrationTestCmd |
There was a problem hiding this comment.
we should revert this change and make use of spawn and env('build')
1. Modifying integration test command with unit test command 2. using spawn instead of runTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable the Java support with osio pipeline library
closes openshiftio/openshift.io#4501
This PR cannot be merged until openshiftio/openshift.io#4500 is closed.