Fix #5608 Support authentication with certificate in exec-credentials

[qingboooo]

Description

Fix #5608

ExecCredentialStatus also contains clientKeyData and clientCertificateData fields

https://kubernetes.io/docs/reference/config-api/client-authentication.v1beta1/#client-authentication-k8s-io-v1beta1-ExecCredentialStatus

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[rohanKanojia]

@qingboooo : Thanks, is it possible to add some test to validate this?

[qingboooo]

@qingboooo : Thanks, is it possible to add some test to validate this?

Thanks for the quick response. For sure, I am now trying to validate it with UT or Regression Test locally

[qingboooo]

@rohanKanojia some checks failed, seems some of them are not related to the code change, see my quick analysis below:

• Build / Java 8 Maven: Failed in UT io.fabric8.crd.generator.zookeeper.ZookeeperCustomResourceTest, but succeeded locally, is it possible an infra/env problem?
• Windows Build / Java 11 Maven: Same as above failure
• Build / Java 11 Maven: Cancelled, I didn't see any failure
• E2E Tests / OpenShift (v3.11.0): Failed to startup OpenShift cluster
• SonarCloud Code Analysis: Test coverage not enough, will update the test to increase the coverage rate

Do you have some suggestions? thanks in advance.

[rohanKanojia]

Openshift CI failure is a known issue #5545 . Other failures might be due to flaky tests

Let's see if we see then on re-runs.

[qingboooo]

Openshift CI failure is a known issue #5545 . Other failures might be due to flaky tests

Let's see if we see then on re-runs.

Thanks, checks are passed, do you have a release plan recently? when this change will be merged?

[rohanKanojia]

It would require review from other team members as well. Maybe in a week or two it might get merged.

[shawkins]

@qingboooo thank you for the pr - the tests look great.

[manusa]

LGTM, thx!

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

82.4% Coverage
0.0% Duplication

The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Catch issues before they fail your Quality Gate with our IDE extension SonarLint