Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump vertx.version from 4.4.6 to 4.5.1 #5645

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2023

Bumps vertx.version from 4.4.6 to 4.5.1.
Updates io.vertx:vertx-core from 4.4.6 to 4.5.1

Commits
  • 942fa22 Releasing 4.5.1
  • 19bc31c Add a test that verifies disabling of TLS 1.3
  • 9227f7a TCPSSLOptions#setKeyCertOptions overrides should not be deprecated
  • e97c825 Improve HttpTest#testConcurrentWrite
  • 1884599 Merge pull request #5029 from eclipse-vertx/custom-jar-file-resolver-4.x
  • 8620d31 Minor
  • 930fd39 Do not extract files ending with a space on windows
  • 1e56721 Change the analyze of the list of entries of a jar URL and use !/ as separato...
  • 500fc28 Get the jar file from JarURLConnection instead of reconstructing the URL from...
  • 84a78c0 Rewrite how unpackFromJarURL gets the list of entries (possibly more than 2) ...
  • Additional commits viewable in compare view

Updates io.vertx:vertx-web-client from 4.4.6 to 4.5.1

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `vertx.version` from 4.4.6 to 4.5.1.

Updates `io.vertx:vertx-core` from 4.4.6 to 4.5.1
- [Commits](eclipse-vertx/vert.x@4.4.6...4.5.1)

Updates `io.vertx:vertx-web-client` from 4.4.6 to 4.5.1

---
updated-dependencies:
- dependency-name: io.vertx:vertx-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: io.vertx:vertx-web-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Dec 14, 2023
@manusa
Copy link
Member

manusa commented Dec 19, 2023

From conversation in #5594

#5594 (comment)

Tests seem to be failing because vertx has added a check for websocket URL scheme to be ws / wss in WebSocketConnectOptions
If I try adding ws schemed URLs in tests I get NullPointerException since MockWebServer doesn't seem to support these.

I kind of recall that I added a workaround for something similar in Jetty.

The relevant code is:

jettyWs.connect(webSocket, Objects.requireNonNull(WebSocket.toWebSocketUri(request.uri())), cur)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@manusa manusa added this to the 6.10.0 milestone Dec 20, 2023
@manusa manusa merged commit 64735c1 into main Dec 20, 2023
16 of 19 checks passed
@manusa manusa deleted the dependabot/maven/vertx.version-4.5.1 branch December 20, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants