Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Canvas): Holding down Shift to select multiple shapes unexpectedly triggers the text exit event #10229

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix(Canvas): Holding down Shift to select multiple shapes unexpectedly triggers the text exit event #10229

merged 4 commits into from
Nov 13, 2024
+31 −1

Conversation

zhe-he
Copy link
Contributor

@zhe-he zhe-he commented Oct 18, 2024

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Oct 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@asturur
Copy link
Member

asturur commented Oct 18, 2024

Please see if you can add a unit test

@zhe-he
Copy link
Contributor Author

zhe-he commented Oct 21, 2024

Please see if you can add a unit test

Added.

@asturur asturur merged commit 0be721d into fabricjs:master Nov 13, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhe-he @asturur