Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting & clean up #27

Open
Joepock123 opened this issue Sep 11, 2020 · 0 comments
Open

Formatting & clean up #27

Joepock123 opened this issue Sep 11, 2020 · 0 comments
Labels
code-review enhancement New feature or request

Comments

@Joepock123
Copy link

You knew this one was coming! In general you code is really clean and nice to read so well done :)

We've all heard the stat that developers end up reading code 80% of the time and for this reason it's super important every project has consistent formatting so setting up eslint and prettier should be one of the first things we do (it really helps people who may not be familiar with the project as well).

Wherever possible we want to reduce cognitive overload from things that could distract us from solving the important problems. Taking formatting off our hands is definitely one of those things!

As a matter of habit it's good to remove console logs you don't need before pushing code to master. You can even set up eslint so that it stops you commiting if your staged code contains any!

@Joepock123 Joepock123 added code-review enhancement New feature or request labels Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant