Skip to content

Commit

Permalink
Do not fail job if subprocess called with ignore_status argument
Browse files Browse the repository at this point in the history
Summary:
Jobs should not be marked as failed if a subprocess has `kwargs["ignore_status"] == True`

Or if "silent" is True

Reviewed By: KarlSimonsen

Differential Revision: D36103193

fbshipit-source-id: 0582681ccc04f5b1e5b0adebb848fdc5e86a77f6
  • Loading branch information
Varun Puri authored and facebook-github-bot committed May 3, 2022
1 parent d216422 commit 159848d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions benchmarking/utils/subprocess_with_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ def processRun(*args, **kwargs):
# TODO: Early stopping -- stop job after a subprocess fails multiple times.
# fail the whole job
if not kwargs.get("silent", False):
getLogger().info("Process Failed after multiple retries.")
setRunStatus(1)
getLogger().info("Process Failed.")
if not kwargs.get("ignore_status", False):
setRunStatus(1)
return ret


Expand Down

0 comments on commit 159848d

Please sign in to comment.