Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor File Storage Code #473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarkAndersonIX
Copy link
Contributor

Summary: Refactors file_storage code, moving classes to bridge module under bridge.file_storage. downloaders are in one subfolder and uploaders can be in another. These have base classes in oss, and concrete implementations in intern code. Specialized child classes can be configured based on application.

Differential Revision: D34268713

Mark Anderson added 2 commits February 17, 2022 11:20
Summary: Everstore is being deprecated, and we should begin updating our code to use Manifold over Everstore.  Sets file_storage to manifold in the config, and adds required arguments to run_lab.py to parse into the file transfer class.  This manifold class can be extended to have various strategies configured for different applications, e.g. upload power data, upload users' output_files etc.

Differential Revision: D34268765

fbshipit-source-id: 498a0db106a8e16b1a0b9b133e6bc5606fbac5f9
Summary: Refactors file_storage code, moving classes to bridge module under bridge.file_storage.  downloaders are in one subfolder and uploaders can be in another.  These have base classes in oss, and concrete implementations in intern code.  Specialized child classes can be configured based on application.

Differential Revision: D34268713

fbshipit-source-id: c17a81473d21ca6cbb34f8b16999c24c37a477f0
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D34268713

@facebook-github-bot
Copy link

Hi @MarkAndersonIX!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants