Restore memory profiling error for OS < 10 for now #529
Conversation
Summary: Restore memory profiling error for OS < 10 for now. The intent was to enable perfetto profiling for OS < 10 by adding sideloading and mostly the old check worked except it still doesn't work due to a permissions problem on certain rooted devices which I still need to fix separately. Reviewed By: Junah-Park Differential Revision: D39913049 fbshipit-source-id: 9b8b7b96d1290f505b84e3ffa590a9d33750e1fa
|
This pull request was exported from Phabricator. Differential Revision: D39913049 |
|
Hi @KarlSimonsen! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
Restore memory profiling error for OS < 10 for now.
The intent was to enable perfetto profiling for OS < 10 by adding sideloading and mostly the old check worked except it still doesn't work due to a permissions problem on certain rooted devices which I still need to fix separately.
Reviewed By: Junah-Park
Differential Revision: D39913049