Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[apple] xcode: change defaultConfigurationIsVisible from bool -> string. #2603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[apple] xcode: change defaultConfigurationIsVisible from bool -> string. #2603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b4e2b
[apple] Change xcconfig defaultConfigurationIsVisible from boolean to…
Mar 25, 2021
229408b
Update mock projects.
Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/com/facebook/buck/apple/xcode/xcodeproj/XCConfigurationList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@
public class XCConfigurationList extends PBXProjectItem {
private List<XCBuildConfiguration> buildConfigurations;
private Optional<String> defaultConfigurationName;
private boolean defaultConfigurationIsVisible;
private String defaultConfigurationIsVisible;

private final LoadingCache<String, XCBuildConfiguration> buildConfigurationsByName;

public XCConfigurationList(AbstractPBXObjectFactory objectFactory) {
buildConfigurations = new ArrayList<>();
defaultConfigurationName = Optional.empty();
defaultConfigurationIsVisible = false;
defaultConfigurationIsVisible = "0";

buildConfigurationsByName =
CacheBuilder.newBuilder()
Expand Down
4 changes: 2 additions & 2 deletions ...ect/testdata/generating_root_directory_project/Project.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04EADDF308200000000</key>
<dict>
Expand Down Expand Up @@ -452,7 +452,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C8479350C8E2F900000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...eatures/apple/project/testdata/project_focus/Apps/Apps.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04EFEC3CBA900000000</key>
<dict>
Expand Down Expand Up @@ -283,7 +283,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793001F3E9200000000</key>
<dict>
Expand Down
6 changes: 3 additions & 3 deletions ...ple/project/testdata/project_focus/Libraries/Dep1/Dep1.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E79CC7D5400000000</key>
<dict>
Expand Down Expand Up @@ -250,7 +250,7 @@
<array>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E79CC7D5500000000</key>
<dict>
Expand Down Expand Up @@ -314,7 +314,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722200000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...ple/project/testdata/project_focus/Libraries/Dep2/Dep2.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0020722300000000</key>
<dict>
Expand Down Expand Up @@ -269,7 +269,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722300000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...apple/project/testdata/project_focus_pattern/Apps/Apps.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0E6F340F00000000</key>
<dict>
Expand Down Expand Up @@ -283,7 +283,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793001F3E9200000000</key>
<dict>
Expand Down
6 changes: 3 additions & 3 deletions ...ect/testdata/project_focus_pattern/Libraries/Dep1/Dep1.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E79CC7D5400000000</key>
<dict>
Expand Down Expand Up @@ -371,7 +371,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E79CC7D5500000000</key>
<dict>
Expand Down Expand Up @@ -435,7 +435,7 @@
<string>49524373A439BFE700000002</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722200000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions .../project/testdata/project_focus_pattern_cell/Apps/Apps.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0E6F340F00000000</key>
<dict>
Expand Down Expand Up @@ -283,7 +283,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793001F3E9200000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...ject/testdata/project_focus_pattern_cell/bar/Dep2/Dep2.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0020722300000000</key>
<dict>
Expand Down Expand Up @@ -269,7 +269,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722300000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...tures/apple/project/testdata/project_focus_with_tests/Dep1/Dep1.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0020722200000000</key>
<dict>
Expand Down Expand Up @@ -231,7 +231,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722200000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...res/apple/project/testdata/project_focus_with_tests/Tests/Tests.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E04CF5E0100000000</key>
<dict>
Expand Down Expand Up @@ -245,7 +245,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C8479304CF5E0100000000</key>
<dict>
Expand Down
10 changes: 5 additions & 5 deletions ...atures/apple/project/testdata/project_halide/Apps/Apps.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0E6F340F00000000</key>
<dict>
Expand Down Expand Up @@ -704,7 +704,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0BC2E52700000000</key>
<dict>
Expand Down Expand Up @@ -791,7 +791,7 @@
<string>49524373A439BFE700000002</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04EC17EBCB700000000</key>
<dict>
Expand Down Expand Up @@ -878,7 +878,7 @@
<string>49524373A439BFE700000003</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04EA17B1C7900000000</key>
<dict>
Expand Down Expand Up @@ -943,7 +943,7 @@
<string>49524373A439BFE700000004</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793001F3E9200000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...t/testdata/project_with_unique_library_names/Apps/Apps.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0E6F340F00000000</key>
<dict>
Expand Down Expand Up @@ -380,7 +380,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793001F3E9200000000</key>
<dict>
Expand Down
6 changes: 3 additions & 3 deletions .../project_with_unique_library_names/Libraries/Libraries.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0020722200000000</key>
<dict>
Expand Down Expand Up @@ -432,7 +432,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0020722300000000</key>
<dict>
Expand Down Expand Up @@ -497,7 +497,7 @@
<string>49524373A439BFE700000002</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793A7E3D27900000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...tV2/testdata/generating_root_directory_project/Project.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04EADDF308200000000</key>
<dict>
Expand Down Expand Up @@ -452,7 +452,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C8479350C8E2F900000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...tures/apple/projectV2/testdata/project_focus/Apps/Apps.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04EFEC3CBA900000000</key>
<dict>
Expand Down Expand Up @@ -283,7 +283,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C84793001F3E9200000000</key>
<dict>
Expand Down
6 changes: 3 additions & 3 deletions ...e/projectV2/testdata/project_focus/Libraries/Dep1/Dep1.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E79CC7D5400000000</key>
<dict>
Expand Down Expand Up @@ -250,7 +250,7 @@
<array>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E79CC7D5500000000</key>
<dict>
Expand Down Expand Up @@ -314,7 +314,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722200000000</key>
<dict>
Expand Down
4 changes: 2 additions & 2 deletions ...e/projectV2/testdata/project_focus/Libraries/Dep2/Dep2.xcodeproj/project.pbxproj.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
<string>49524373A439BFE700000000</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>E66DC04E0020722300000000</key>
<dict>
Expand Down Expand Up @@ -269,7 +269,7 @@
<string>49524373A439BFE700000001</string>
</array>
<key>defaultConfigurationIsVisible</key>
<false/>
<string>0</string>
</dict>
<key>96C847930020722300000000</key>
<dict>
Expand Down
Loading