Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): a11y fix on mobile DropdownNavbarItem #10898

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Feb 4, 2025

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

A while ago a focus fix for DropdownNavbarItems was landed (https://github.com/facebook/docusaurus/pull/6003/files) which didn't apply to the mobile version. This mirrors the same logic for the mobile one.

Relates microsoft/playwright.dev#1631

Test Plan

yarn build && yarn start:website and navigate via tabbing over the mobile navbar.

Test links

Deploy preview: https://deploy-preview-10898--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 4, 2025
Copy link

netlify bot commented Feb 4, 2025

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c48ffea
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67a35ad1020f7300084f4415
😎 Deploy Preview https://deploy-preview-10898--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 4, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 55 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 52 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 60 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 62 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@mxschmitt mxschmitt force-pushed the fix-mobile-dropdownnavbaritem branch from 15ee2a2 to c48ffea Compare February 5, 2025 12:34
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 6, 2025
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems like it fixes the keyboard focus issue 👍

@slorber slorber merged commit 3fde4a0 into facebook:main Feb 6, 2025
39 checks passed
@slorber slorber changed the title fix(core): a11y fix on mobile DropdownNavbarItem fix(theme): a11y fix on mobile DropdownNavbarItem Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants