Introduce GitLab Releases Provider #3
Conversation
This commit implements a GitLab Releases provider, modeled after the GitHub Releases provider. It uses the `glab` command line interface (CLI) to handle downloads, and delegates to that CLI for error handling. I did experiment briefly with using the Rust `glob` crate to eagerly identify errors in glob patterns passed for matching artifacts, but that crate didn't exactly match the Go `path/filepath.Match` [1] logic and I didn't want to introduce any weird incompatibilities between the two layers. [1]: https://pkg.go.dev/path/filepath#Match Signed-off-by: Andrew Lilley Brinker <[email protected]>
|
Hi @alilleybrinker! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
alilleybrinker
changed the title
NOTE: This is still a draft. I haven't yet tested it out against a GitLab Release to ensure it does the right thing. This is just the initial code modeled after the GitHub Releases provider implementation.
This commit implements a GitLab Releases provider, modeled after the GitHub Releases provider. It uses the
glabcommand line interface (CLI) to handle downloads, and delegates to that CLI for error handling.I did experiment briefly with using the Rust
globcrate to eagerly identify errors in glob patterns passed for matching artifacts, but that crate didn't exactly match the Gopath/filepath.Matchlogic and I didn't want to introduce any weird incompatibilities between the two layers.Related: #2