Only verify verifiable events

Summary: To be consistent with the legacy implementation, we should only send a validation result for events that are validated (i.e. purchases, subscriptions, and restored events). We also update the default quantity to be 1 when the transaction is nil because we cannot have a purchase for a quantity of 0.

Reviewed By: jjiang10

Differential Revision: D65005873

fbshipit-source-id: bd31adf9622357e68135ae1fd6fe09c7f7e6d477

FBSDKCoreKit/FBSDKCoreKit/AppEvents/Internal/IAP/IAPConstants.swift

@@ -19,6 +19,13 @@ enum IAPConstants {
   static let IAPSDKLibraryVersions = "SK1-SK2"
   static let eventsForReceipt: Set<AppEvents.Name> = [.purchased, .subscribe, .startTrial]
   static let dedupableEvents: Set<AppEvents.Name> = [.purchased, .subscribe, .startTrial]
+  static let verifiableEvents: Set<AppEvents.Name> = [
+    .purchased,
+    .subscribe,
+    .startTrial,
+    .purchaseRestored,
+    .subscribeRestore,
+  ]
   static let manuallyLoggedDedupableEventsKey = "com.facebook.sdk:ManualDedupableEventsKey"
   static let implicitlyLoggedDedupableEventsKey = "com.facebook.sdk:ImplicitDedupableEventsKey"
 }

FBSDKCoreKit/FBSDKCoreKit/AppEvents/Internal/IAP/IAPEvent.swift

@@ -34,4 +34,8 @@ struct IAPEvent: Equatable {
   var shouldAppendReceipt: Bool {
     storeKitVersion == .version1 && IAPConstants.eventsForReceipt.contains(eventName)
   }
+
+  var isClientSideVerifiable: Bool {
+    storeKitVersion == .version2 && IAPConstants.verifiableEvents.contains(eventName)
+  }
 }

FBSDKCoreKit/FBSDKCoreKit/AppEvents/Internal/IAP/IAPEventResolver.swift

@@ -168,7 +168,7 @@ extension IAPEventResolver {
       productTitle: product.displayName,
       productDescription: product.description,
       amount: transaction?.price ?? product.price,
-      quantity: transaction?.purchasedQuantity ?? 0,
+      quantity: transaction?.purchasedQuantity ?? 1,
       currency: currency ?? product.priceFormatStyle.currencyCode,
       transactionID: transactionID,
       originalTransactionID: originalTransactionID,

FBSDKCoreKit/FBSDKCoreKit/AppEvents/Internal/IAP/IAPTransactionLogger.swift

@@ -95,7 +95,7 @@ extension IAPTransactionLogger {
     } else {
       parameters[.inAppPurchaseType] = IAPType.product.rawValue
     }
-    if event.storeKitVersion == .version2 {
+    if event.isClientSideVerifiable {
       parameters[.validationResult] = event.validationResult?.rawValue ?? IAPValidationResult.unverified.rawValue
     }
     if event.shouldAppendReceipt, let receipt = fetchDeviceReceipt() {

FBSDKCoreKit/FBSDKCoreKitTests/Internal/AppEvents/IAP/IAPTests/IAPEventResolverTests.swift

@@ -459,7 +459,7 @@ extension IAPEventResolverTests {
       productTitle: product.displayName,
       productDescription: product.description,
       amount: 0.99,
-      quantity: 0,
+      quantity: 1,
       currency: "USD",
       transactionID: nil,
       originalTransactionID: nil,
@@ -494,7 +494,7 @@ extension IAPEventResolverTests {
       productTitle: product.displayName,
       productDescription: product.description,
       amount: 3,
-      quantity: 0,
+      quantity: 1,
       currency: "USD",
       transactionID: nil,
       originalTransactionID: nil,

FBSDKCoreKit/FBSDKCoreKitTests/Internal/AppEvents/IAP/IAPTests/IAPTransactionLoggerTests.swift

@@ -962,7 +962,7 @@ extension IAPTransactionLoggerTests {
       return self.eventLogger.capturedEventName == .purchaseFailed &&
         self.eventLogger.capturedValueToSum == 0.99 &&
         capturedParameters[.contentID] as? String == product.id &&
-        capturedParameters[.numItems] as? Int == 0 &&
+        capturedParameters[.numItems] as? Int == 1 &&
         (capturedParameters[.transactionDate] as? String)?.isEmpty == true &&
         (capturedParameters[.productTitle] as? String)?.isEmpty == true &&
         (capturedParameters[.description] as? String)?.isEmpty == true &&
@@ -992,7 +992,7 @@ extension IAPTransactionLoggerTests {
       return self.eventLogger.capturedEventName == .subscribeFailed &&
         self.eventLogger.capturedValueToSum == 2.0 &&
         capturedParameters[.contentID] as? String == product.id &&
-        capturedParameters[.numItems] as? Int == 0 &&
+        capturedParameters[.numItems] as? Int == 1 &&
         (capturedParameters[.transactionDate] as? String)?.isEmpty == true &&
         (capturedParameters[.productTitle] as? String)?.isEmpty == true &&
         (capturedParameters[.description] as? String)?.isEmpty == true &&