Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for JSON string #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add check for JSON string #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/exceptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ export class FacebookRequestError extends FacebookError {
}
}

function isJsonString(str) {
try {
JSON.parse(str);
} catch (e) {
return false;
}
return true;
}
/**
* Error response has several structures depended on called APIs or errors.
* This method contructs and formats the response into the same structure for
Expand Down Expand Up @@ -75,7 +83,7 @@ function constructErrorResponse(response: Object) {
if (response.name === STATUS_CODE_ERROR) {
// Handle when we can get response error code
body = response.error ? response.error : response;
body = typeof body === 'string' ? JSON.parse(body) : body;
body = typeof body === 'string' && isJsonString(body) ? JSON.parse(body) : body;
// Construct an error message from subfields in body.error
message = body.error.error_user_msg
Comment on lines +86 to 88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the body is a string. it will fail here...

? `${body.error.error_user_title}: ${body.error.error_user_msg}`
Expand Down