Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uninitialized constant FacebookAds::ServerSide::EventRequest::OpenStruct (NameError) #211

Closed
wants to merge 2 commits into from

Conversation

ka2n
Copy link
Contributor

@ka2n ka2n commented Apr 18, 2024

NameError

uninitialized constant FacebookAds::ServerSide::EventRequest::OpenStruct (NameError)

        json_response_object = JSON.parse(JSON.generate(response), object_class: OpenStruct)
                                                                                 ^^^^^^^^^^

Requiring OpenStruct are optional since json gem v2.7.2.
https://github.com/flori/json/releases/tag/v2.7.2

@facebook-github-bot
Copy link

Hi @ka2n!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ka2n ka2n changed the title fix: requre ostruct fix: require ostruct Apr 20, 2024
@ka2n ka2n changed the title fix: require ostruct fix: uninitialized constant FacebookAds::ServerSide::EventRequest::OpenStruct (NameError) Apr 22, 2024
ka2n and others added 2 commits April 22, 2024 15:03
…enStruct (NameError)

require OpenStruct are optional since json gem v2.7.2
@facebook-github-bot
Copy link

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@stcheng merged this pull request in 2870776.

@ka2n ka2n deleted the patch-1 branch August 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants