bug Disregarding AndroidSdkRoot, if SdkUseEmbedded is enabled when building for Android.
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fresh Unity installations the `AndroidSdkRoot` editor pref is not set. They rather default to `SdkUseEmbedded` set to true. Before the fix, we were unable to build unless an SDK path was explicitly set, even if the "Use Embedded SDK" option was enabled. Facebook SDK was not allowing to export a project without an Android SDK Root path explicitly set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for proposing a pull request!
To help us review the request, please complete the following:
bugfor bug fixes)Pull Request Details
In fresh Unity installations the
AndroidSdkRooteditor pref is not set. They rather default to the tools installed with the editor (SdkUseEmbeddedset to true).Before the fix, we were unable to build unless a correct SDK path was explicitly set, even if the
SdkUseEmbeddedoption was enabled.By checking the
SdkUseEmbeddedboolean first we can mitigate the problem.The code can be further optimized by getting the set
AndroidSdkRootin an else statement, but I don't know if that's within the scope of this fix.Test Plan
Test Plan: Add your test plan here