-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tahan: config: adjusted sensor config to support 2nd source #296
base: main
Are you sure you want to change the base?
Conversation
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
In the line 940 (not sure, please confirm) This needs to be changed to (That is, adding /) Can you make this change, and update the PR, @zhongedward ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the meta internal test failing. Asked for further revision.
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
@zhongedward has updated the pull request. You must reimport the pull request before landing. |
@mikechoifb Ok, I have modified it, please review, thanks. |
Description
This PR is for tahan 2nd source sensor service.
Motivation
1.Than 2nd source sensor list is as following:
https://docs.google.com/spreadsheets/d/1r0Vbv1cx3KelYLEM4vl0VNyIeEpFwurG5JJZ6BckMCI/edit?gid=1266933266#gid=1266933266
2.Currently,all the SMB number combinations and COME number combinations are as follows,in the future if factories have new numbers, we should add them.
3.In platform config, adjust SMBFRU_SLOT to SMB_FRU_SLOT,adjust BCB_SLOT.
4.Test Plan
1.The correctness of the format has been verified on this website https://jsonlint.com/
2.Used jq cmd to pretty the format.
3.Test log as follows:
Tested both in janga dvt main source & janga dvt 2nd source machine.
tahan 2nd source tested log:
tahan main source tested log:
tahan_dvt_2nd_source_platform_test_log.txt tahan_dvt_2nd_source_sensor_test_log.txt tahan_dvt_platform_test_log.txt tahan_dvt_sensor_test_log.txt
FYI: the sensor_hw_test_log:
tahan_dvt_2nd_source_sensor_hw_test_log.txt
tahan_dvt_sensor_hw_test_log.txt