Skip to content

Commit

Permalink
Upgrade Xcode version and iPhone version in Github Actions (#1420)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1420

Now `macos-latest` aliases to `macos-14`, where `xcode-13.4.1` is not
available. Upgrade it to 15.4. Also use iPhone 14 simulator instead of
11 due to error of "test must be run on concrete device".

Reviewed By: neildhar

Differential Revision: D58144748

fbshipit-source-id: 09747fc5d99f1457902800bb44940c5e1d7fc516
  • Loading branch information
lavenzg authored and facebook-github-bot committed Jun 7, 2024
1 parent dcf8e7b commit 9e2bbf8
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@ jobs:
macos:
runs-on: macos-latest
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
with:
path: hermes
Expand Down Expand Up @@ -115,9 +115,9 @@ jobs:
HERMES_WS_DIR: "/tmp/hermes"
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
- name: Cache setup
uses: actions/[email protected]
Expand All @@ -142,9 +142,9 @@ jobs:
test-macos:
runs-on: macos-latest
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
with:
path: hermes
Expand All @@ -163,9 +163,9 @@ jobs:
HERMES_WS_DIR: "/tmp/hermes"
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
- name: Cache setup
uses: actions/[email protected]
Expand All @@ -192,10 +192,12 @@ jobs:
working-directory: test/ApplePlatformsIntegrationTestApp
- name: Test iPhone application
run: |-
# Xcode 15 uses iOS 17 for simulator, and only iPhone 14/15 can work by
# default, so use the oldest working model here.
xcodebuild test \
-workspace ApplePlatformsIntegrationTests.xcworkspace \
-configuration Debug \
-destination 'platform=iOS Simulator,name=iPhone 11' \
-destination 'platform=iOS Simulator,name=iPhone 14' \
-scheme ApplePlatformsIntegrationMobileTests
working-directory: test/ApplePlatformsIntegrationTestApp
package-apple-runtime:
Expand All @@ -208,9 +210,9 @@ jobs:
HERMES_WS_DIR: "/tmp/hermes"
HOMEBREW_NO_AUTO_UPDATE: 1
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
- name: Cache setup
uses: actions/[email protected]
Expand Down Expand Up @@ -550,9 +552,9 @@ jobs:
test-macos-test262:
runs-on: macos-latest
steps:
- uses: maxim-lobanov/setup-xcode@v1.6.0
- uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: 13.4.1
xcode-version: 15.4
- uses: actions/[email protected]
with:
path: hermes
Expand Down

0 comments on commit 9e2bbf8

Please sign in to comment.