Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the pointer of owning object in GCPointer::set() part I #1502

Open
wants to merge 14 commits into
base: static_h
Choose a base branch
from

Conversation

lavenzg
Copy link
Contributor

@lavenzg lavenzg commented Sep 6, 2024

Differential Revision: D62222257

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

lavenzg added a commit to lavenzg/hermes that referenced this pull request Oct 22, 2024
…k#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 3a9fa2a to 10ecb83 Compare October 22, 2024 01:48
lavenzg added a commit to lavenzg/hermes that referenced this pull request Nov 8, 2024
…k#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 10ecb83 to 65d3797 Compare November 8, 2024 01:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

lavenzg added a commit to lavenzg/hermes that referenced this pull request Nov 14, 2024
…k#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 65d3797 to 30a6c7a Compare November 14, 2024 21:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

lavenzg added a commit to lavenzg/hermes that referenced this pull request Nov 21, 2024
…k#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 30a6c7a to 02dfb5c Compare November 21, 2024 19:16
lavenzg added a commit to lavenzg/hermes that referenced this pull request Nov 22, 2024
…k#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 02dfb5c to e18bee9 Compare November 22, 2024 23:57
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

lavenzg added a commit to lavenzg/hermes that referenced this pull request Nov 23, 2024
…k#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from e18bee9 to 2d81068 Compare November 23, 2024 00:08
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

lavenzg added a commit to lavenzg/hermes that referenced this pull request Nov 28, 2024
…thod (facebook#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 2d81068 to 503a099 Compare November 28, 2024 01:27
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

lavenzg added a commit to lavenzg/hermes that referenced this pull request Dec 2, 2024
…thod (facebook#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 503a099 to d97ca85 Compare December 2, 2024 18:22
lavenzg added a commit to lavenzg/hermes that referenced this pull request Dec 10, 2024
…thod (facebook#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from d97ca85 to 58acd20 Compare December 10, 2024 00:19
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

Differential Revision: D61675022
…er (facebook#1504)

Summary:
Pull Request resolved: facebook#1504

Large segment needs to be backed by a large storage size.
StorageProvider currently always allocate fixed size of storage
determined by HERMESVM_LOG_HEAP_SEGMENT_SIZE.

This diffs adds support of allocating larger storage with below
changes:
1. `newStorage()` and `deleteStorage()` takes additional `sz` parameter.
2. For `MallocStorageProvider` and `VMAllocateStorageProvider`, simply
change the previous fixed storage size to passed in `sz`.
3. For `ContiguousVAStorageProvider`, use a BitVector to manage
allocations and deallocations. This can be improved later if we observe
fragmentations.

The support of enabling different sizes of heap segment will be added
later.

Differential Revision: D61676721
Differential Revision: D61747499
Differential Revision: D61807366
…s to AlignedHeapSegmentBase

Differential Revision: D64713261
Differential Revision: D65638502
Differential Revision: D62171114
…ers (facebook#1513)

Summary: Pull Request resolved: facebook#1513

Differential Revision: D62169632
…wning cell to ctor of GCHermesValueBase

Differential Revision: D62196480
…thod (facebook#1502)

Summary: Pull Request resolved: facebook#1502

Differential Revision: D62222257
@lavenzg lavenzg force-pushed the export-D62222257-to-static_h branch from 58acd20 to 270b69b Compare December 10, 2024 06:14
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62222257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants