Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing changes to accRoles #16

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

fabOnReact
Copy link
Contributor

@fabOnReact fabOnReact commented Feb 7, 2023

reverts the changes to accessibilityRoles. The original PR is under review facebook/react-native#35130

based on comment facebook/react-native#35130 (comment), the prop accessibilitySpan was separated from accessibilityRole

Related #15

@yungsters
Copy link
Contributor

Thanks, @fabriziobertoglio1987.

Question for you and maybe also @cortinico — When should I publish a major release for this package that incorporates these changes? I'm thinking we may want to do one release that includes any other changes that will go out in the next React Native release.

@fabOnReact
Copy link
Contributor Author

fabOnReact commented Feb 8, 2023

@yungsters Today, I will review all my previously merged PRs and verify if other changes are required.
https://www.npmjs.com/package/deprecated-react-native-prop-types/v/2.2.0 was last released two months ago.

This PR reverts the changes introduced with #15 (merged in the main three weeks ago). Does not add any new changes to the existing functionalities.

PR #17 is in DRAFT, and it may introduce a new prop type (accessibilitySpan).

Thanks a lot.🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants