Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Invalid props.style key transformOrigin supplied to Image." #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix "Invalid props.style key transformOrigin supplied to Image." #33

wants to merge 1 commit into from

Conversation

retyui
Copy link

@retyui retyui commented May 15, 2024

issue: #32

@NickGerleman
Copy link
Contributor

We no longer include PropTypes in RN 0.74, so I'm not sure if we would want to do a new release for this and backport to 0.73. @yungsters do you have any thoughts?

@retyui
Copy link
Author

retyui commented May 16, 2024

@NickGerleman 0.74.x is fresh release , not all proj. were migrated yet)

@cipolleschi
Copy link

My 2cents on this is that we should backport this.
The React Native release window support is 3 versions, so right now it is 0.72, 0.73 and 0.74.
We should release packages for 0.72 and 0.73, if we need.

@retyui
Copy link
Author

retyui commented Jun 27, 2024

@cipolleschi @NickGerleman can we merge this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed shared with meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@retyui @NickGerleman @cipolleschi @facebook-github-bot