Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style updates for content banner #4421

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 4, 2025

Add a border radius to the content banner and fix its width for improved layout consistency.

before
image

after
image

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 166b3c6
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6779bf58caade000082e9ad0
😎 Deploy Preview https://deploy-preview-4421--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea behind the left offset is to align content not the wrapper/decoration, which is also reasonable. Don't have strong opinion on that one, but in general would be nice to have a bit more context, and the details on the changes you decide to make.

@Simek Simek merged commit 5548cc1 into facebook:main Jan 5, 2025
4 checks passed
@hichemfantar hichemfantar deleted the better-border-radius branch January 5, 2025 20:03
@hichemfantar
Copy link
Contributor Author

In this case, I just wanted it to look like the other banners in the theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants