Remove unused scrollbar styles from themes #4422
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think that those scrollbars are used and don't see anything wrong with them. In contrast, I think that they offer more control and flexibility for the developers, allowing to unify the overall appearance of website, no matter which platform or browser user uses.. Can you explain few points from you take?
What exactly you have in mind by that? Does the scrollbars hinder or negatively affect the code base?
Have you tried to fix the spotted issue? Can you elaborate a bit more when they work and when not, and what is an expected behavior in your eyes?
Can you explain a bit more that statement? I would say that the functionally the scrollbars are the same, no matter how they styled. What are the resources or stats you are basing your observations about users expectations on? |
|
I checked the places where the custom scrollbar is being applied in the css (main scrollbar, main sidenav, blog sidebar, table of contents, codeblock) and they all use the native scrollbar. I believe these custom styles are from the v1 to v2 migration and are now broken and are being overwritten by docusaurus.
Well this is from personal experience and other devs i worked with agreed with me but here's a collection of forums where the matter was heavily discussed. |
|
Feel free to open both versions side by side and let me know if you find a difference because so far I couldn't find any. |
|
@Simek I added a screenshot for visual proof in the original post |
Eliminate unnecessary scrollbar styles from both shared and custom themes to streamline the codebase.
they seem to only work partially on codeblocks but even then it's always better to rely on native scrollbars as they behave more closely to user expectations. especially now that native scrollbars support the thin variant which docusaurus already applies at the right places.