Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: kotlin SoLoader.init params to fix "library 'libhermes_executor.so' not found #4432

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

deepktp
Copy link
Contributor

@deepktp deepktp commented Jan 8, 2025

As per react native 0.76 release breaking changes documentation updated kotlin integration.

Kotlin integration code example missed the changes.

0.76 breaking changes

Issue
#4430

…or.so' not found" error

As per react native 0.76 release breaking changes documentation updated kotlin integration.
@facebook-github-bot
Copy link

Hi @deepktp!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 7b7cbcf
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/677eb05be7ba680008fdecb3
😎 Deploy Preview https://deploy-preview-4432--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you apply the same change also to this file:

website/versioned_docs/version-0.76/_integration-with-existing-apps-kotlin.md

?

Other than that, the change looks good to me

@cortinico cortinico merged commit e2f210d into facebook:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants