Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TYPE_VIEW_HOVER_ENTER to AccessibilityNodeInfo sendAccessibilityEvent #34969

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
fd0923e
adding accessibilityTitle prop to ReactAndroid
fabOnReact Oct 13, 2022
accbbfc
improve types in java and js
fabOnReact Oct 17, 2022
17d7827
implementing alternative solution for iOS/Android
fabOnReact Oct 24, 2022
5e1e72f
Merge branch 'main' into modal-title
fabOnReact Oct 24, 2022
42ab164
moving Title logic to modal rn-tester example
fabOnReact Oct 25, 2022
5c7ed5e
removing changes from Modal
fabOnReact Oct 25, 2022
98b4a94
fix issues with sendAccessibilityEvent
fabOnReact Oct 25, 2022
0fe1e3e
refactor useTimer with useEffect
fabOnReact Oct 25, 2022
4213491
minor fix to example
fabOnReact Oct 25, 2022
f89a01f
fix ref flow type in example
fabOnReact Oct 26, 2022
9e7fe9f
eslint fix check
fabOnReact Oct 26, 2022
129d152
minor change
fabOnReact Oct 26, 2022
036e4b5
Merge branch 'main' into modal-title
fabOnReact Oct 26, 2022
8a25a6f
minor change
fabOnReact Oct 26, 2022
dbd01c6
minor change
fabOnReact Oct 26, 2022
3c0f531
avoid passing vars to setTimeout
fabOnReact Oct 26, 2022
23bf335
Merge branch 'main' into modal-title
fabOnReact Nov 18, 2022
43e2ffa
remove sendAccessibilityEvent setTimeout as not required on iOS
fabOnReact Nov 18, 2022
8f2e0f0
adding flowfixme
fabOnReact Nov 18, 2022
d351891
Merge branch 'main' into modal-title
fabOnReact Nov 28, 2022
3126e49
Add viewHoverEnter to sendAccessibilityEventFromJS
fabOnReact Nov 28, 2022
ef5e490
remove state modalOpened
fabOnReact Nov 28, 2022
4cf1605
remove state modalOpened
fabOnReact Nov 28, 2022
e7f0023
adding viewHoverInfo to AccessiblityInfo
fabOnReact Nov 28, 2022
fd152d2
minor change
fabOnReact Nov 28, 2022
bf37a34
using correct flow type
fabOnReact Nov 28, 2022
dc4c54e
remove example
fabOnReact Nov 29, 2022
69f6a18
Merge branch 'main' into modal-title
fabOnReact Nov 29, 2022
a5c0cd8
Merge branch 'main' into modal-title
fabOnReact Feb 13, 2023
8debb60
remove AccInfo.flow.js
fabOnReact Feb 13, 2023
b5f3b21
Merge branch 'main' into modal-title
fabOnReact Feb 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type AccessibilityAnnouncementFinishedEventHandler = (
event: AccessibilityAnnouncementFinishedEvent,
) => void;

type AccessibilityEventTypes = 'click' | 'focus';
type AccessibilityEventTypes = 'click' | 'focus' | 'viewHoverEnter';

/**
* @see https://reactnative.dev/docs/accessibilityinfo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type AccessibilityEventDefinitions = {
screenReaderChanged: [boolean],
};

type AccessibilityEventTypes = 'click' | 'focus';
type AccessibilityEventTypes = 'click' | 'focus' | 'viewHoverEnter';

// Mapping of public event names to platform-specific event names.
const EventNames: Map<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,8 @@ public void sendAccessibilityEventFromJS(int surfaceId, int reactTag, String eve
eventType = AccessibilityEvent.TYPE_WINDOW_STATE_CHANGED;
} else if ("click".equals(eventTypeJS)) {
eventType = AccessibilityEvent.TYPE_VIEW_CLICKED;
} else if ("viewHoverEnter".equals(eventTypeJS)) {
eventType = AccessibilityEvent.TYPE_VIEW_HOVER_ENTER;
} else {
throw new IllegalArgumentException(
"sendAccessibilityEventFromJS: invalid eventType " + eventTypeJS);
Expand Down