Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate the logic for counting attachments #42596

Closed
wants to merge 1 commit into from
Closed

De-duplicate the logic for counting attachments #42596

wants to merge 1 commit into from

Conversation

cubuspl42
Copy link
Contributor

Summary:

De-duplicate the logic for counting attachments.

This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.

Changelog:

[INTERNAL] [CHANGE] - De-duplicate the logic for counting attachments

Test Plan:

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 22, 2024
@cubuspl42
Copy link
Contributor Author

@rozele Any chance you could review this?

@analysis-bot
Copy link

analysis-bot commented Jan 22, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,066,833 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,450,443 +11
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: cfc0ba0
Branch: main

@cubuspl42 cubuspl42 mentioned this pull request Jan 23, 2024
Open
@cubuspl42
Copy link
Contributor Author

@rozele I took a look at the "build_npm_package" check and it seems unrelated to my changes 🙂

cipolleschi
cipolleschi requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cubuspl42, thanks for the PR. I left a couple of comments.
One is just a nit, but the other is related to function visibility and public API and I think it would be better to address it.

What are your thoughts on this suggestion?

packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.cpp Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.cpp Outdated Show resolved Hide resolved
@cubuspl42 cubuspl42 force-pushed the deduplicate-countAttachments branch from 822e5aa to c7281d7 Compare January 24, 2024 12:49
cipolleschi
cipolleschi reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some concrete suggestions on how to move forward.

packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.cpp Outdated Show resolved Hide resolved
packages/react-native/ReactCommon/react/renderer/attributedstring/AttributedString.h Outdated Show resolved Hide resolved
...er/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp Outdated Show resolved Hide resolved
...er/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp Outdated Show resolved Hide resolved
@cubuspl42 cubuspl42 force-pushed the deduplicate-countAttachments branch from c7281d7 to 16479a3 Compare January 29, 2024 10:40
cipolleschi
cipolleschi approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your understanding and for applying the fixes.
CI is red but it is not due this PR: this morning Cocoapods released a new version (1.1.5.0) which is breaking. See more here.

@cubuspl42
Copy link
Contributor Author

@cipolleschi Thank you for reviewing and approving this PR! What is the next action point here? 🙂

@cipolleschi
Copy link
Contributor

/rebase - this comment automatically rebase the PR on top of main

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

I'm soooo sorry! I was sure we already merged this PR in main. 🤦
I'll proceed importing and have it landed.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 20, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 69977d0.

@cubuspl42 cubuspl42 mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cubuspl42 @analysis-bot @cipolleschi @facebook-github-bot