Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract fragment conversions to separate functions #42597

Closed

Conversation

cubuspl42
Copy link
Contributor

Summary:

Extract fragment conversions to separate functions to make refactoring easier and simplify reasoning about the code.

This code is being modified later.

This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.

Changelog:

[INTERNAL] [CHANGE] - Extract fragment conversions to separate functions

Test Plan:

...to make refactoring easier and simplify reasoning about the code.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 22, 2024
@cubuspl42
Copy link
Contributor Author

@robhogan Any chance you could review this?

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,951,079 +5,896
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,334,844 +2,344
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 6d77d7b
Branch: main

Copy link
Contributor

@robhogan robhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand these are being extracted for reuse to support different fragment types in a PR coming soon? LGTM.

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cubuspl42
Copy link
Contributor Author

@robhogan Kind of! I'm modifying the whole structure, adding another layer on top of fragments (the codename for that layer is "shards"). I'm doing all I can to make the diff of the upcoming "substantial" changes as easy to review as possible, so I'm submitting a wave of smaller PRs cleaning up the relevant codebase fragments.

@cubuspl42

This comment was marked as outdated.

@cubuspl42
Copy link
Contributor Author

@robhogan Thank you so much for the quick review! If you are in a reviewing mood, you can also take a look at one or two similar tiny PRs: (my PRs) 😄

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 23, 2024
@facebook-github-bot
Copy link
Contributor

@robhogan merged this pull request in 2722f95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants