-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract fragment conversions to separate functions #42597
Conversation
...to make refactoring easier and simplify reasoning about the code.
@robhogan Any chance you could review this? |
Base commit: 6d77d7b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand these are being extracted for reuse to support different fragment types in a PR coming soon? LGTM.
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@robhogan Kind of! I'm modifying the whole structure, adding another layer on top of fragments (the codename for that layer is "shards"). I'm doing all I can to make the diff of the upcoming "substantial" changes as easy to review as possible, so I'm submitting a wave of smaller PRs cleaning up the relevant codebase fragments. |
Summary:
Extract fragment conversions to separate functions to make refactoring easier and simplify reasoning about the code.
This code is being modified later.
This is a minor improvement in the context of my multi-PR work on react-native-community/discussions-and-proposals#695.
Changelog:
[INTERNAL] [CHANGE] - Extract fragment conversions to separate functions
Test Plan: