-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Android ImageManger #47721
Open
dmytrorykun
wants to merge
1
commit into
facebook:main
Choose a base branch
from
dmytrorykun:export-D65753319
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 19, 2024
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
November 19, 2024 17:49
0536973
to
7cb8717
Compare
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
November 20, 2024 10:11
7cb8717
to
f2783ed
Compare
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
force-pushed
the
export-D65753319
branch
from
November 22, 2024 14:29
f2783ed
to
f2e3fcc
Compare
This pull request was exported from Phabricator. Differential Revision: D65753319 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 22, 2024
Summary: Pull Request resolved: facebook#47721 This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 23, 2024
Summary: This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as `RCTImageManager.mm` for iOS. Changelog: [Internal] Differential Revision: D65753319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff splits Cxx ImageManger into Cxx and Android variants. They both are currently no-op, but the Android one will be used for image prefetching, just as
RCTImageManager.mm
for iOS.Changelog: [Internal]
Differential Revision: D65753319