Fix no return static analysis error in SchedulerPriorityUtils.h #47911
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
| @@ -50,6 +50,9 @@ static inline std::chrono::milliseconds timeoutForSchedulerPriority( | |||
| return std::chrono::seconds(10); | |||
| case SchedulerPriority::IdlePriority: | |||
| return std::chrono::minutes(5); | |||
| default: | |||
| react_native_assert(false && "Unsupported SchedulerPriority value"); | |||
There was a problem hiding this comment.
Nit: could you place the return outside the switch/case? Otherwise this suppresses any Clang warnings for switch/case exhaustiveness if a new enum value is added.
There was a problem hiding this comment.
We also do LOG(FATAL) in some places which is marked as [[noreturn]], and will run in release builds, but either should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In react-native-windows our static analysis tools report an error for
timeoutForSchedulerPrioritydue to cases where it may not always return a value. This is an upstreaming of the patch we have to fix that error.Changelog:
[INTERNAL] [FIXED] - Fix no return static analysis error in SchedulerPriorityUtils.h
Test Plan:
Building should be sufficient.