Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstrate bug in differentiator where reparented nodes reference non-existent nodes #48002

Closed
wants to merge 1 commit into from
Closed

Demonstrate bug in differentiator where reparented nodes reference non-existent nodes #48002

wants to merge 1 commit into from

Commits on Nov 28, 2024

  1. Demonstrate bug in differentiator where reparented nodes reference no… 

    …n-existent nodes

Summary:
Demonstrates the issue identified in facebook#47960 and a crash we've been seeing internally around `getViewState` referencing a view that does not exist.

When reparenting unflattened nodes, Differentiator may emit an `update` with a `parentShadowView` that does not exist on the native side yet, thereby crashing Android.

Landing the test-case first (with some test cleanup), so the diff for the actual fix is clearer.

Changelog: [Internal]

Differential Revision: D66557919
    @javache @facebook-github-bot
    javache authored and facebook-github-bot committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    d51e316 View commit details
    Browse the repository at this point in the history