build: add prebuild command support

facebook · Feb 23, 2025 · 31abe51 · 31abe51
1 parent 80a1dfb
commit 31abe51
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 5 deletions.
diff --git a/fixtures/eslint-v6/build.mjs b/fixtures/eslint-v6/build.mjs
@@ -7,6 +7,7 @@ import {fileURLToPath} from 'node:url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
-exec('yarn build -r stable eslint-plugin-react-hooks', {
+execSync('yarn build -r stable eslint-plugin-react-hooks', {
   cwd: resolve(__dirname, '..', '..'),
+  stdio: 'inherit',
 });
diff --git a/fixtures/eslint-v7/build.mjs b/fixtures/eslint-v7/build.mjs
@@ -7,6 +7,7 @@ import {fileURLToPath} from 'node:url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
-exec('yarn build -r stable eslint-plugin-react-hooks', {
+execSync('yarn build -r stable eslint-plugin-react-hooks', {
   cwd: resolve(__dirname, '..', '..'),
+  stdio: 'inherit',
 });
diff --git a/fixtures/eslint-v8/build.mjs b/fixtures/eslint-v8/build.mjs
@@ -7,6 +7,7 @@ import {fileURLToPath} from 'node:url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
-exec('yarn build -r stable eslint-plugin-react-hooks', {
+execSync('yarn build -r stable eslint-plugin-react-hooks', {
   cwd: resolve(__dirname, '..', '..'),
+  stdio: 'inherit',
 });
diff --git a/fixtures/eslint-v9/build.mjs b/fixtures/eslint-v9/build.mjs
@@ -7,6 +7,7 @@ import {fileURLToPath} from 'node:url';
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 
-exec('yarn build -r stable eslint-plugin-react-hooks', {
+execSync('yarn build -r stable eslint-plugin-react-hooks', {
   cwd: resolve(__dirname, '..', '..'),
+  stdio: 'inherit',
 });
diff --git a/packages/eslint-plugin-react-hooks/package.json b/packages/eslint-plugin-react-hooks/package.json
@@ -21,7 +21,6 @@
     "react"
   ],
   "scripts": {
-    "dependencies": "cd ../../compiler/packages/babel-plugin-react-compiler && yarn && yarn tsc -b",
     "test": "jest",
     "typecheck": "tsc --noEmit"
   },

diff --git a/scripts/rollup/build.js b/scripts/rollup/build.js
@@ -12,6 +12,7 @@ const stripBanner = require('rollup-plugin-strip-banner');
 const chalk = require('chalk');
 const resolve = require('@rollup/plugin-node-resolve').nodeResolve;
 const fs = require('fs');
+const childProcess = require('child_process');
 const argv = require('minimist')(process.argv.slice(2));
 const Modules = require('./modules');
 const Bundles = require('./bundles');
@@ -829,6 +830,11 @@ function handleRollupError(error) {
   }
 }
 
+function runShellCommand(command) {
+  console.log(chalk.dim('Running: ') + chalk.cyan(command));
+  childProcess.execSync(command, {stdio: 'inherit', shell: true});
+}
+
 async function buildEverything() {
   if (!argv['unsafe-partial']) {
     await asyncRimRaf('build');
@@ -876,6 +882,9 @@ async function buildEverything() {
 
   // eslint-disable-next-line no-for-of-loops/no-for-of-loops
   for (const [bundle, bundleType] of bundles) {
+    if (bundle.prebuild) {
+      runShellCommand(bundle.prebuild);
+    }
     await createBundle(bundle, bundleType);
   }
 

diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js
@@ -1197,6 +1197,8 @@ const bundles = [
     wrapWithModuleBoundaries: false,
     externals: [],
     tsconfig: './packages/eslint-plugin-react-hooks/tsconfig.json',
+    prebuild:
+      'cd compiler/packages/babel-plugin-react-compiler && yarn && yarn tsc -b',
   },
 
   /******* React Fresh *******/