Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixture reproduction for enableOwnerStacks error perf #32329

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented Feb 7, 2025

Reproduces a dev perf regression we see internally with enableOwnerStacks turned on and lots of JSX element creation.

@react-sizebot
Copy link

Comparing: 8759c5c...b4641c9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.48 kB 515.43 kB = 92.04 kB 92.03 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 558.52 kB 558.46 kB = 99.27 kB 99.25 kB
facebook-www/ReactDOM-prod.classic.js = 636.88 kB 636.83 kB = 111.92 kB 111.91 kB
facebook-www/ReactDOM-prod.modern.js = 627.20 kB 627.15 kB = 110.34 kB 110.33 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-prod.js = 358.66 kB 357.92 kB = 62.37 kB 62.27 kB
react-native/implementations/ReactFabric-profiling.js = 383.98 kB 383.16 kB = 66.08 kB 65.98 kB
facebook-www/React-dev.classic.js = 71.75 kB 71.44 kB = 15.60 kB 15.54 kB
facebook-www/React-dev.modern.js = 71.75 kB 71.44 kB = 15.60 kB 15.54 kB
facebook-react-native/react/cjs/React-dev.js = 67.16 kB 66.85 kB = 14.78 kB 14.72 kB
facebook-www/React-profiling.classic.js = 21.48 kB 21.20 kB = 5.46 kB 5.40 kB
facebook-www/React-profiling.modern.js = 21.48 kB 21.20 kB = 5.46 kB 5.40 kB
facebook-www/React-prod.classic.js = 21.04 kB 20.76 kB = 5.38 kB 5.32 kB
facebook-www/React-prod.modern.js = 21.04 kB 20.76 kB = 5.38 kB 5.32 kB
facebook-react-native/react/cjs/React-profiling.js = 19.97 kB 19.68 kB = 5.15 kB 5.09 kB
facebook-react-native/react/cjs/React-prod.js = 19.53 kB 19.25 kB = 5.07 kB 5.01 kB

Generated by 🚫 dangerJS against a7aa1fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants