Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow] Eliminate usage of global React types in ReactNativeTypes.js #32330

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SamChou19815
Copy link
Contributor

Summary

Flow will remove these types from global library definition soon. This PR replaces them in the ReactNativeTypes first, because this file will be synced to the react-native repo.

How did you test this change?

flow

@react-sizebot
Copy link

react-sizebot commented Feb 7, 2025

Comparing: cd90a4d...43d0705

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.48 kB 515.48 kB = 92.04 kB 92.04 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 558.52 kB 558.52 kB = 99.27 kB 99.27 kB
facebook-www/ReactDOM-prod.classic.js = 636.88 kB 636.88 kB = 111.92 kB 111.92 kB
facebook-www/ReactDOM-prod.modern.js = 627.20 kB 627.20 kB = 110.34 kB 110.34 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/shims/ReactNativeTypes.js +1.84% 8.55 kB 8.71 kB +2.82% 2.27 kB 2.33 kB

Generated by 🚫 dangerJS against b8e6454

@SamChou19815 SamChou19815 marked this pull request as draft February 7, 2025 18:58
@SamChou19815 SamChou19815 force-pushed the remove-global-react-types branch from 1f77ae4 to aeb95e4 Compare February 7, 2025 19:03
@SamChou19815 SamChou19815 marked this pull request as ready for review February 7, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants