[RN] Move definition of public instances to ReactNativePrivateInterface #32446
+66
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
requested review from
javache,
yungsters,
rickhanlonii and
huntie
|
Comparing: 9b042f9...77181dd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 22, 2025
Summary: Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Differential Revision: D69996009
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Differential Revision: D69996009
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Differential Revision: D69996009
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009
huntie
approved these changes
Feb 24, 2025
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: #49602 Changelog: [internal] This just prepares for the removal of some types from `ReactNativeTypes`, and defines some types in `ReactNativePrivateInterface` that `ReactNativeTypes` expects to be defined after facebook/react#32446 Reviewed By: huntie Differential Revision: D69996009 fbshipit-source-id: 3c156b4dede8e217d6a828ab310533a2f8bfd42c
github-actions bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…ce (#32446) ## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in #26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook/react-native#49602 and verified Flow passes. DiffTrain build for [9dd378f](9dd378f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This only modifies types, so shouldn't have an impact at runtime.
Some time ago we moved some type definitions from React to React Native in #26437.
This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React.
This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods).
How did you test this change?
Manually synced
ReactNativeTypeson top of facebook/react-native#49602 and verified Flow passes.