Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: only override __PCLMUL__ on MSVC #13006

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rexicon226
Copy link

Hello!

We ran into issues when compiling RocksDB to x86-64-v3 and other targets which have avx but not pclmul. I believe the code is doing something different from what the comment is saying. This overrides __PCLMUL__ for all compilers, not just MSVC, which caused us to bring in intrinsics that weren't supported by the target.

Is there a better way of solving this?

@facebook-github-bot
Copy link
Contributor

Hi @Rexicon226!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants