Support building on AIX 7.2 with Clang #13397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current test status on AIX 7.2: 98% tests passed, 302 tests failed out of 12159 |
ZarkoT
reviewed
Feb 13, 2025
There was a problem hiding this comment.
I think we also need `(OS_AIX) here: https://github.com/facebook/rocksdb/blob/main/env/io_posix.cc#L31
| @@ -43,7 +43,7 @@ | |||
| #include <sys/types.h> | |||
| #define PLATFORM_IS_LITTLE_ENDIAN (BYTE_ORDER == LITTLE_ENDIAN) | |||
| #include <alloca.h> | |||
| #elif defined(OS_FREEBSD) || defined(OS_OPENBSD) || defined(OS_NETBSD) || \ | |||
| #elif defined(OS_AIX) || defined(OS_FREEBSD) || defined(OS_OPENBSD) || defined(OS_NETBSD) || \ | |||
| defined(OS_DRAGONFLYBSD) || defined(OS_ANDROID) | |||
| #include <sys/endian.h> | |||
There was a problem hiding this comment.
I don't think we have sys/endian.h on AIX. You can use sys/machine.h for the ENDIAN macros.
| @@ -58,7 +58,7 @@ Copyright (c) 2006, 2015, Percona and/or its affiliates. All rights reserved. | |||
| #include <stdint.h> | |||
| #include <sys/time.h> | |||
| #include <time.h> | |||
| #if defined(__powerpc__) | |||
| #if !defined(OS_AIX) && defined(__powerpc__) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch supports basic operations needed for building RocksDB on AIX 7.2 with Clang or IBM OpenXL C/C++ for AIX
Changes
-mcmodel=largeas globals exceeds small table of content.env/fs_posix.cc,port/port_posix.h, andtoku_time.h.