Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versioning Guide #148

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Versioning Guide #148

merged 3 commits into from
Sep 14, 2022

Conversation

amyreese
Copy link
Member

@amyreese amyreese commented Mar 18, 2022 •
edited
Loading

@amyreese amyreese added the documentation Improvements or additions to documentation label Mar 18, 2022
@amyreese amyreese added this to the 1.1 milestone Mar 18, 2022
@amyreese amyreese requested a review from thatch March 18, 2022 00:49
@amyreese amyreese self-assigned this Mar 18, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2022
@amyreese amyreese modified the milestones: 1.1, 1.0.x Sep 13, 2022
thatch
thatch reviewed Sep 13, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
thatch
thatch reviewed Sep 13, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
thatch
thatch reviewed Sep 13, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
thatch
thatch reviewed Sep 13, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
thatch
thatch reviewed Sep 13, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
@amyreese amyreese marked this pull request as ready for review September 13, 2022 21:30
thatch
thatch reviewed Sep 14, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
thatch
thatch reviewed Sep 14, 2022
View reviewed changes
docs/versioning.rst Outdated Show resolved Hide resolved
thatch
thatch approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@thatch thatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I still think #187 / #188 is not being represented correctly. It was not an exception.

@amyreese amyreese merged commit 6cadcde into facebook:main Sep 14, 2022
@amyreese amyreese deleted the versioning branch September 14, 2022 21:25
amyreese added a commit to amyreese/usort that referenced this pull request Sep 14, 2022
@amyreese
Merge pull request facebook#148 from amyreese/versioning
f71b90e 
Versioning Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatch thatch thatch approved these changes

Assignees

@amyreese amyreese

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@amyreese @thatch @facebook-github-bot