This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
[determinator] initial Windows support #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
force-pushed
the
win
branch
3 times, most recently
from
64aef98 to
fd265a0
Compare
sunshowers
changed the title
sunshowers
force-pushed
the
win
branch
3 times, most recently
from
8fc10be to
999ff28
Compare
Including on Windows -- required for cross-platform consistency.
sunshowers
force-pushed
the
win
branch
2 times, most recently
from
0629826 to
93812af
Compare
Oh, Windows. Disable all conversions entirely.
We weren't producing proper TOML, whoops. Also, no longer silently ignore non-Unicode paths.
This seems to work but I haven't managed to test it very much.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This likely addresses #263.