This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
Display jsonlint error in parsing .mention-bot file with syntax error #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffreyleeon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @saiqulhaq, @vjeux and @jgardella to be potential reviewers. |
vjeux
approved these changes
Nov 29, 2016
| @@ -19,6 +19,7 @@ var util = require('util'); | |||
| var schedule = require('./schedule.js'); | |||
|
|
|||
| var GitHubApi = require('github'); | |||
| var jsonlint = require("jsonlint"); | |||
| @@ -166,12 +168,20 @@ async function work(body) { | |||
| }).catch(function(e) { | |||
| if (e instanceof SyntaxError && repoConfig.actions.indexOf(data.action) !== -1) { | |||
| // Syntax error while reading custom configuration file | |||
| var errorLog = ''; | |||
| try { | |||
| jsonlint.parse(e.repoConfig) | |||
|
Awesome! Thanks, this is an awesome output. Please tweak the little quote and i'll merge it in :) |
|
@jeffreyleeon Very cool! |
jeffreyleeon
force-pushed
the
display-jsonlint-error
branch
from
f15a5fd to
e0ef073
Compare
|
@jeffreyleeon updated the pull request - view changes |
|
YAY |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #188