This repository was archived by the owner on Jan 1, 2025. It is now read-only.
[Proposal] Include Recoil Nexus in the package. #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Thanks for this contribution @luisanton-io! Though, we should explore some of the nuances of the interface for consideration. It seems like this API would have race conditions in case there are multiple |
|
I see. Hopefully I will have some time to check into this soon. Thanks for the heads up |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by multiple users[1][2][3] and considering the recent traction of Recoil Nexus, hopefully we can include this feature directly in the package.
I am not particularly happy I had to extract
RecoilRootfrom its original module to avoid a circular dependency withuseRecoilCallback.This has led me to rename the exports everywhere from
/Recoil_RecoilRootto/Recoil_RecoilNexus, tests included.If this is a big deal any hint to avoid doing so is welcome.
Cheers,
L