Skip to content
This repository was archived by the owner on Jan 1, 2025. It is now read-only.

Failing testcase for sync setSelf bug #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdlavin
Copy link

@mdlavin mdlavin commented Apr 24, 2021

Even after the new 0.2.0 release including a fix for #774 I'm still seeing a problem with a synchronous setSelf call not taking effect immediately. I've narrowed it down to a fairly small testcase that demonstrates the problem.

There are two code tweaks you can make to the testcase that will cause it to pass, and they might highlight where the underlying bug is:

  1. If you remove the async modifier here the test passes
  2. If you flip the order of the dependencies here, then the test passes

@facebook-github-bot
Copy link
Contributor

Hi @mdlavin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@drarmstr
Copy link
Contributor

drarmstr commented May 6, 2021

@csantos42 - Think this is related to #998?

@drarmstr drarmstr requested a review from csantos42 May 6, 2021 06:39
@drarmstr drarmstr added the bug Something isn't working label May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants