Skip to content

Commit

Permalink
[antlir2][genrule_in_image] delete test for installed par
Browse files Browse the repository at this point in the history
Summary:
This is much more complicated with live mode opt-by-default pars.
Just delete this test and plan to tell any users that experience this same
failure that they have to use `$(exe)` instead.

Test Plan: testhard

Reviewed By: naveedgol

Differential Revision: D68335138

fbshipit-source-id: c20fe3c6e198a642d6c38a50af932df1437339c5
  • Loading branch information
vmagro authored and facebook-github-bot committed Jan 24, 2025
1 parent 6e300ce commit 65c81fa
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
21 changes: 0 additions & 21 deletions antlir/antlir2/genrule_in_image/tests/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -112,26 +112,6 @@ genrule_in_image(
layer = ":with-xarexec",
)

image.layer(
name = "with-par",
features = [
feature.install(
src = ":par",
dst = "/par",
),
],
parent_layer = ":with-xarexec",
)

genrule_in_image(
name = "run-installed-par",
out = "f",
bash = """
/par $OUT
""",
layer = ":with-par",
)

image.layer(
name = "mount-src",
features = [
Expand Down Expand Up @@ -176,7 +156,6 @@ python_unittest(
"DEFAULT_OUT": "$(location :default-out)",
"DOT_DIR": "$(location :dot-dir)",
"EXE_PAR": "$(location :run-exe-par)",
"INSTALLED_PAR": "$(location :run-installed-par)",
"NAMED_DIR": "$(location :named-dir)",
"NAMED_OUTS": "$(location :named-outs)",
"SINGLE_FILE": "$(location :single-file)",
Expand Down
5 changes: 0 additions & 5 deletions antlir/antlir2/genrule_in_image/tests/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ def test_exe_par(self) -> None:
self.assertTrue(f.exists())
self.assertEqual(f.read_text(), "From par\n")

def test_installed_par(self) -> None:
f = Path(os.getenv("INSTALLED_PAR"))
self.assertTrue(f.exists())
self.assertEqual(f.read_text(), "From par\n")

def test_with_mount(self) -> None:
f = Path(os.getenv("WITH_MOUNT"))
self.assertTrue(f.exists())
Expand Down

0 comments on commit 65c81fa

Please sign in to comment.