Skip to content

Commit

Permalink
[S470934] Back out "[antlir] label images as heavyweight"
Browse files Browse the repository at this point in the history
Summary:
Adding heavyweight label to all layer_rule targets seems to introduced > 10% more fbcode continuous run jobs ..

For S470934 , backing out the labelling change. Let's sync on how to address the original issue without regressing the capacity usage..

Test Plan:
```
./run_orchestrator.py -p fbcode -h 4f4dd98604612fcc884ada7b919fc0516505c89c -s continuous -m dev -e enable_v2_target_metadata
```
https://www.internalfb.com/sandcastle/workflow/2517512191705200409

Reviewed By: epilatow

Differential Revision: D66377691

fbshipit-source-id: 94d93135ff87c09254588fae9ee42df9bda0f3d8
  • Loading branch information
Xiang Gao authored and facebook-github-bot committed Nov 22, 2024
1 parent b31d199 commit fc47292
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions antlir/antlir2/bzl/image/layer.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -747,10 +747,6 @@ def layer(
if not rootless:
kwargs["labels"] = selects.apply(kwargs.pop("labels", []), lambda labels: labels + ["uses_sudo"])

# Mark images as heavyweight for CI
if "heavyweight" not in kwargs.get("labels", []):
kwargs["labels"] = kwargs.pop("labels", []) + ["heavyweight"]

# Annoyingly, we can only accept target_compatible_with because we need to
# indicate a *HARD* requirement for `os:linux`, which is impossible with
# compatible_with, and the two cannot be mixed
Expand Down

0 comments on commit fc47292

Please sign in to comment.