[antlir][oss] some ci fixes #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64256300 |
vmagro
added a commit
that referenced
this pull request
Oct 11, 2024
Summary: Pull Request resolved: #264 Use nightly Rust compiler and enable the `nightly` feature of `hashbrown` so that it compiles (see rust-lang/hashbrown#564) This wouldn't really be a problem if we correctly copied the internally used versions of Rust libraries, but we miss crate versions in most cases so sometimes skew causes problems like this. Disable broken sendstream test Fix #219 Test Plan: Export to PR Differential Revision: D64256300
vmagro
force-pushed
the
export-D64256300
branch
from
4a159a3 to
4153f1e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64256300 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64256300 |
vmagro
added a commit
that referenced
this pull request
Oct 11, 2024
Summary: Pull Request resolved: #264 Use nightly Rust compiler and enable the `nightly` feature of `hashbrown` so that it compiles (see rust-lang/hashbrown#564) This wouldn't really be a problem if we correctly copied the internally used versions of Rust libraries, but we miss crate versions in most cases so sometimes skew causes problems like this. Disable broken sendstream test Fix #219 Test Plan: Export to PR Differential Revision: D64256300
vmagro
force-pushed
the
export-D64256300
branch
from
4153f1e to
7aef60a
Compare
Summary: Pull Request resolved: #264 Use nightly Rust compiler and enable the `nightly` feature of `hashbrown` so that it compiles (see rust-lang/hashbrown#564) This wouldn't really be a problem if we correctly copied the internally used versions of Rust libraries, but we miss crate versions in most cases so sometimes skew causes problems like this. Disable broken sendstream test Fix #219 Test Plan: Export to PR Differential Revision: D64256300
|
This pull request was exported from Phabricator. Differential Revision: D64256300 |
vmagro
force-pushed
the
export-D64256300
branch
from
7aef60a to
69d51d1
Compare
|
This pull request has been merged in 7391888. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use nightly Rust compiler and enable the
nightlyfeature ofhashbrownsothat it compiles (see rust-lang/hashbrown#564)
This wouldn't really be a problem if we correctly copied the internally used
versions of Rust libraries, but we miss crate versions in most cases so
sometimes skew causes problems like this.
Disable broken sendstream test
Fix #219
Test Plan: Export to PR
Differential Revision: D64256300