fix(fuzzer): Fix toSql methods for NestedLoopJoinNode in Reference Query Runners #11576
+72
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
✅ Deploy Preview for meta-velox canceled.
|
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…ry Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…ry Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 18, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
de208a3
to
bc6a7db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
changed the title
DanielHunte
force-pushed
the
export-D66132514
branch
from
bc6a7db
to
23a672d
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 19, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 19, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Differential Revision: D66132514
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
kagamiori
approved these changes
Nov 19, 2024
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
23a672d
to
10d42c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
10d42c8
to
c950c66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
c950c66
to
a2784d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
a2784d1
to
67e6511
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
67e6511
to
14db48f
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 21, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 22, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
added 2 commits
November 25, 2024 00:32
…eferenceQueryRunners (facebookincubator#11566) Summary: This change updates both the DuckQueryRunner and PrestoQueryRunner to parse filters in their hasJoinNode toSql methods. Differential Revision: D66021799
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
force-pushed
the
export-D66132514
branch
from
14db48f
to
76dfcc8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66132514 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Nov 25, 2024
…ery Runners (facebookincubator#11576) Summary: The select clause is completely missing in the produced query string. Reviewed By: kagamiori Differential Revision: D66132514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The select clause is completely missing in the produced query string.
Differential Revision: D66132514