Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change enable_sorted_aggregations gflag to true by default #8112

Closed
wants to merge 5 commits into from
Closed

Change enable_sorted_aggregations gflag to true by default #8112

wants to merge 5 commits into from

Conversation

kgpai
Copy link
Contributor

@kgpai kgpai commented Dec 20, 2023 •
edited
Loading

  1. Aggregations with 'enable_sorted_aggregations' set have been succeeding for last week. Setting this to true by default.
  2. We also remove the scheduled runs from 'experimental' , so that we can run only when required.

Experimental run : https://github.com/facebookincubator/velox/actions/runs/7269489622

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 605426b
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/65823b4b713c7c0008dfe81a

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mbasmanova mbasmanova changed the title Set gflag 'enable_sorted_aggregations' to be true by default Change enable_sorted_aggregations gflag to true by default Dec 20, 2023
mbasmanova
mbasmanova approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 4fe3738.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 4fe3738d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova approved these changes

@kagamiori kagamiori Awaiting requested review from kagamiori

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgpai @facebook-github-bot @mbasmanova